fix: tns preview warns incorrectly for exceeding file size limit #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check in `tns preview` relies on the zipped content instead of checking the actual file content. This way, based on what is the zipped content, we may end up with 30000 bytes length for 15 MB input files or for 100KBs input. The check is not correct, it should rely on the input file size, as when extracted on device, their size is the actual limitation.
KristianDD
approved these changes
Sep 28, 2018
Fatme
approved these changes
Sep 30, 2018
|
run ci |
2 similar comments
|
run ci |
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check in
tns previewrelies on the zipped content instead of checking the actual file content. This way, based on what is the zipped content, we may end up with 30000 bytes length for 15 MB input files or for 100KBs input.The check is not correct, it should rely on the input file size, as when extracted on device, their size is the actual limitation.
PR Checklist
What is the current behavior?
tns previewshows warning that file size limit is exceeded even for small projects.What is the new behavior?
tns previewshows warning only when input files that have to be transferred are larger than 15MBs