fix: passing --hmr must always set bundle option to "webpack" #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Sep 26, 2018
lib/options.ts
Outdated
| private $staticConfig: Config.IStaticConfig, | ||
| private $settingsService: ISettingsService) { | ||
|
|
||
| this.options = _.extend({}, this.commonOptions, this.options, this.globalOptions); |
There was a problem hiding this comment.
this.options = _.extend({}, this.commonOptions, this.globalOptions);
this.options is always an empty dictionary, so no need to use it.
In case `--hmr` is passed, CLI should set the `bundle` option to `webpack`. This works for normal command, but in case it is command that has its own specific `--options` (commands from extensions), CLI calls `validateOptions` again and resets the value set to `--bundle`. In order to fix the behavior, set the `bundle` option to "webpack" directly in the setArgv method which is called every time.
As we do not have submodule anymore, remove the `OptionsBase` class and move the implementation to `Options` class. Remove the `lib/common/options.ts` file and the `ICommonOptions` interface. Replace the usage of `ICommonOptions` with `IOptions`. Fix the unit tests of `lib/common/test/unit-tests/common-options` to use `Options` instead of `OptionsBase` and apply some changes in the passed options in the tests, so they can be valid now. Move the tests to `test/options.ts`
rosen-vladimirov
force-pushed
the
vladimirov/fix-hmr-bundle
branch
from
f09b905 to
6c354ad
Compare
Fatme
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
--hmris passed, CLI should set thebundleoption towebpack. This works for normal command, but in case it is command that has its own specific--options(commands from extensions), CLI callsvalidateOptionsagain and resets the value set to--bundle.In order to fix the behavior, set the
bundleoption to "webpack" directly in the setArgv method which is called every time.refactor: remove OptionsBase and move logic to Options
As we do not have submodule anymore, remove the
OptionsBaseclass and move the implementation toOptionsclass.Remove the
lib/common/options.tsfile and theICommonOptionsinterface.Replace the usage of
ICommonOptionswithIOptions.Fix the unit tests of
lib/common/test/unit-tests/common-optionsto useOptionsinstead ofOptionsBaseand apply some changes in the passed options in the tests, so they can be valid now. Move the tests totest/options.tsPR Checklist
What is the current behavior?
tns cloud run android --hmr --accountId 1does not use webpack build.What is the new behavior?
tns cloud run android --hmr --accountId 1uses webpack build and HMR is applied.