Skip to content

fix: unable to create project from scoped package template #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented Sep 25, 2018

In case you try to create application from scoped package, for example @nativescript/some-package-name, CLI fails with npm install error.
The problem is that CLI thinks everything after @ is a version and sets the package name that has to be installed to empty string.
Fix the parsing and add tests

PR Checklist

What is the current behavior?

The following command fails:

tns create myApp --template "@angular/core" 

What is the new behavior?

The following command succeeds:

tns create myApp --template "@angular/core" 

Fixes issue #3934

In case you try to create application from scoped package, for example `@nativescript/some-package-name`, CLI fails with `npm install` error.
The problem is that CLI thinks everything after `@` is a version and sets the package name that has to be installed to empty string.
Fix the parsing and add tests
@rosen-vladimirov rosen-vladimirov merged commit 077131b into master Sep 26, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-project-create-scoped-packages branch September 26, 2018 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants