Skip to content

fix: don't fail if some unhandled error occurs in application #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Sep 25, 2018

PR Checklist

What is the current behavior?

If some error is thrown from application, {N} CLI stops command execution

What is the new behavior?

If some error is thrown from application, {N} CLI does not stop command execution

Steps to reproduce:

  1. Run tns preview command
  2. Scan QR code
  3. Throw some error from application

@Fatme Fatme changed the title fix: don't fail if some unhandled errors occurs in application fix: don't fail if some unhandled error occurs in application Sep 25, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Sep 25, 2018

run ci

@Fatme Fatme merged commit edc3b11 into master Sep 25, 2018
@Fatme Fatme deleted the fatme/unhandled-error-preview branch September 25, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants