Skip to content

fix: native frameworks/code is added to tns_modules dir #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented Sep 21, 2018

The <project dir>/platforms/<platform>/.../tns_modules directory should contain only the .js code of the application. However, in case nativescript plugin is installed in the node_modules directory of another package (not directly inside the project), its platforms directory is copied to tns_modules as well. This leads to error when trying to build application that has such structure with Xcode 10.
After copying the node_modules to tns_modules recursively remove all platforms directories of all nativescript plugins inside node_modules.

PR Checklist

What is the current behavior?

Build with Xcode fails when nativescript plugin is installed as dependency in node_modules (i.e. it is not installed directly in the node_modules dir of the project.

What is the new behavior?

Build succeeds

Fixes #3932

The `<project dir>/platforms/<platform>/.../tns_modules` directory should contain only the `.js` code of the application. However, in case nativescript plugin is installed in the `node_modules` directory of another package (not directly inside the project), its platforms directory is copied to `tns_modules` as well. This leads to error when trying to build application that has such structure with Xcode 10.
After copying the `node_modules` to `tns_modules` recursively remove all `platforms` directories of all nativescript plugins inside node_modules.
@rosen-vladimirov rosen-vladimirov merged commit 6310203 into master Sep 25, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-copy-frameworks branch September 25, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants