feat: remove requirement for Android Support Repository local installation #3923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would need to set 26.0.0 as a threshold for allowed older support versions though. In order to clean up NativeScript/NativeScript#6129 (comment) (restore animator API usage) and limit the breaking changes in core modules we need android.support.v4.app.Fragment that supports both animations and animators and it seems this was introduced with 26.0.0: https://developer.android.com/sdk/support_api_diff/26.0.0/changes (older support library Fragments worked only with animations). |
|
run ci |
…ation
In the past there was a requirement to have a local installation of the Android Support Repository in order to use libraries from there. However, since some time, the new versions are not downloaded locally and they must be used from the Google repository.
Currently this is not possible in NativeScript as {N} CLI always passes the Support Library version to gradle based on the local installation.
Remove the requirement for local installation and never pass the version to gradle. This way the apps will use the value specified in the `build.gradle` and they can overwrite it in `app.gradle`.
Update nativescript-doctor to latest version, which allows building project without local Androud Support Repository
rosen-vladimirov
force-pushed
the
vladimirov/remove-android-support-library-requirement
branch
from
bda15ed to
178abc2
Compare
endarova
added a commit
to NativeScript/nativescript-cli-tests
that referenced
this pull request
Sep 25, 2018
|
run ci |
DimitarTachev
approved these changes
Sep 25, 2018
rosen-vladimirov
deleted the
vladimirov/remove-android-support-library-requirement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past there was a requirement to have a local installation of the Android Support Repository in order to use libraries from there. However, since some time, the new versions are not downloaded locally and they must be used from the Google repository.
Currently this is not possible in NativeScript as {N} CLI always passes the Support Library version to gradle based on the local installation.
Remove the requirement for local installation and never pass the version to gradle. This way the apps will use the value specified in the
build.gradleand they can overwrite it inapp.gradle.Update nativescript-doctor to latest version, which allows building project without local Androud Support Repository
PR Checklist
What is the current behavior?
You cannot use new versions of Android Support Library. Defining it in
app.gradlestill does not allow you to use newer version, as CLI overwrites the value. Also you cannot build NativeScript projects in case you do not have local version of the Android Support Repository.What is the new behavior?
app.gradle. In case you do not specify it, a default value will be used (set inbuild.gradle).Fixes issue #3773
BREAKING CHANGES:
Existing applications that are using older runtime (not 5.0.0 one), but are built with CLI 5.0.0, may experience some changes - until now CLI was always passing parameter to gradle
-PsupportVersion=26.0.0-alpha1. As CLI no longer passes this version, the default one frombuild.gradlewill be used (for example 27.0.1). In case you want to use the old version in your application, add the following in yourapp.gradle: