Pass the HMR option to the hooks and preview URL #3907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
suggested changes
Sep 18, 2018
There was a problem hiding this comment.
You need to add the option in the following file:
https://github.com/NativeScript/nativescript-cli/pull/3907/files#diff-ce2a772bf174b37fc93372c01de3302cL691
lib/commands/preview.ts
Outdated
| }); | ||
|
|
||
| await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp(); | ||
| await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp({ useHmr: this.$options.hmr }); |
There was a problem hiding this comment.
We can unify useHmr option name with useHotModuleReload
await this.$playgroundQrCodeGenerator.generateQrCodeForCurrentApp({ useHotModuleReload: this.$options.hmr })
| @@ -10,7 +10,7 @@ declare global { | |||
| interface IPreviewAppLiveSyncData extends IProjectDir, IAppFilesUpdaterOptionsComposition, IEnvOptions { } | |||
|
|
|||
| interface IPreviewSdkService { | |||
| qrCodeUrl: string; | |||
| getQrCodeUrl(options: { useHmr: boolean }): string; | |||
There was a problem hiding this comment.
We can use IHasUseHotModuleReloadOption interface here
getQrCodeUrl(options: IHasUseHotModuleReloadOption): string;
| @@ -255,7 +268,7 @@ function execute(options: { | |||
| }); | |||
| } | |||
|
|
|||
| describe("previewAppLiveSyncService", () => { | |||
| describe.only("previewAppLiveSyncService", () => { | |||
DimitarTachev
force-pushed
the
tachev/preview-hmr
branch
5 times, most recently
from
849fa5f to
d5cb873
Compare
DimitarTachev
force-pushed
the
tachev/preview-hmr
branch
from
d5cb873 to
c2a47b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
related to #3813