chore: don't show warnings for {N} plugins without native code when bundle option is provided #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undle option is provided
rosen-vladimirov
suggested changes
Sep 18, 2018
| return this.isNativeScriptPlugin(localPlugin) && !this.hasNativeCode(localPlugin, platform); | ||
| } | ||
|
|
||
| private isNativeScriptPlugin(localPlugin: string): boolean { |
There was a problem hiding this comment.
I think we can move this method to pluginsService.
| } | ||
|
|
||
| private hasNativeCode(localPlugin: string, platform: string): boolean { | ||
| const nativeFolderPath = path.join(this.$projectData.projectDir, NODE_MODULES_DIR_NAME, localPlugin, "platforms", platform.toLowerCase()); |
There was a problem hiding this comment.
"platforms" -> PLATFORMS_DIR_NAME from constants
rosen-vladimirov
approved these changes
Sep 18, 2018
DimitarTachev
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
A warning is shown for plugin with only .js files when
tns preview --bundlecommand is executedWhat is the new behavior?
A warning is not shown for plugin with only .js files when
tns preview --bundlecommand is executed