fix: remove using of $options for hmr usage
#3877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `useHotModuleReload` option in the LiveSyncData, so we will not have to use `$options` in order to determine if `hmr` is passed. This way the logic will work in Sidekick as well. Delete --liveEdit option as it is no longer used.
Set the result of the `useHotModuleReload` in the result of the LiveSync operation, so the code that decides if app should be restarted will have access to the passed value.
Fatme
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: remove using of
$optionsfor hmr usage …Introduce
useHotModuleReloadoption in the LiveSyncData, so we will not have to use$optionsin order to determine ifhmris passed.This way the logic will work in Sidekick as well.
Delete --liveEdit option as it is no longer used.