Skip to content

add switch to set projectName from package.json #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

madmas
Copy link
Contributor

@madmas madmas commented Sep 3, 2018

As projekt_name is used in quite a lot places throuout the project and one might have the need to adjust it aber a while in the project, I propose to provide a setting for that.
I realized that when I had the need to adjust the BuildableName and BlueprintName for IOS: https://github.com/NativeScript/ios-runtime/search?q=__PROJECT_NAME__&unscoped_q=__PROJECT_NAME__

Please let me know what you think about the proposal. If it's wanted, I'll extend the PR to meet the requirements.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

As projekt_name is used in quite a lot places throuout the project and one might have the need to adjust it aber a while in the project, I propose to provide a setting for that.
I realized that when I had the need to adjust the BuildableName and BlueprintName for IOS: https://github.com/NativeScript/ios-runtime/search?q=__PROJECT_NAME__&unscoped_q=__PROJECT_NAME__
@rosen-vladimirov
Copy link
Contributor

rosen-vladimirov commented Oct 1, 2018

Hey @madmas ,
First of all, please excuse me for this so late reply. We definitely like the idea of setting projectName in the package.json. One thing that should be considered is the ability to have different project names for iOS and Android. So I imagine we can have something like this in the nativescript key:

{
    "id": "org.nativescript.myAppId",
    "projectName": {
        "ios": "iosAppName",
        "android": "androidAppName"
    }
}

Note, we already support the scenario, where the id in the nativescript key can be either string or an object.
We'll be glad to assist you further in case you decide to implement this approach.

@hettiger
Copy link

hettiger commented Oct 4, 2018

"id": "org.nativescript.myAppId",

It should also be possible to specify different id's for android and ios.

@madmas
Copy link
Contributor Author

madmas commented Oct 4, 2018

@hettiger there is a PR open for what you are requesting, I think: #3120

@rosen-vladimirov
Copy link
Contributor

Hey @madmas ,
I'm closing this PR, feel free to contact us in case you need more details about the implementation of the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants