fix: fix the activity regex in order to match activities with capital letters

[DimitarTachev]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
• Tests for the changes are included.

What is the current behavior?

We cannot start applications with a custom activity containing capital letters in their package names.

What is the new behavior?

We can start those applications.

Related to #3818

[DimitarTachev]

run ci

[Fatme]

run ci

[Fatme]

run ci

[RoyiNamir]

@DimitarTachev @Fatme @tsonevn
Hi.

I saw the fix with the new regex. . But still there is a subtle warning here.
You've fixed the capital matching in the REPEATING parts to be [a-zA-Z] - but you left the rule that the immediate NEXT LETTER should be capital.

In other words you still enforce this : *.*.[capital]*

The enforcement :

You can see it here :

Full match :

but if I change .M to .m then no match :

if it was delibirate , then fine. but if it wasnt , it should be changed.

This will prevent people from naming activities like org.app.nativescript ( looking at a lowercase- n)

[DimitarTachev]

Hi @RoyiNamir,

Thanks for pointing into that. By convention, all Java classes should start with a capital letter. That's the reason for having this part of the regex just after the last dot. Its matching the activity class name.