Skip to content

fix: use pid logcat option only on supported Android devices #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

No logs are shown for older than 7.0.0 Android Devices (the adb logcat call was throwing an exception as the --pid option is not supported before 7.0.0).

What is the new behavior?

We show logs for all Android devices.

@DimitarTachev DimitarTachev merged commit 2f442b6 into release Aug 8, 2018
@DimitarTachev DimitarTachev deleted the tachev/fix-android-logs branch August 8, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants