feat: add create plugin command #3800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `tns plugin create` command - add documentation - add tests
|
run ci |
rosen-vladimirov
suggested changes
Aug 22, 2018
lib/commands/plugin/create-plugin.ts
Outdated
| const cwd = path.join(projectDir, "src"); | ||
| try { | ||
| spinner.start(); | ||
| await this.$childProcess.exec("npm i", { cwd: cwd }); |
There was a problem hiding this comment.
Instead of using childProcess.exec, you can use the $npm:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/node-package-manager.ts#L18
For example:
await this.$npm.install(cwd, cwd);
lib/commands/plugin/create-plugin.ts
Outdated
| } | ||
|
|
||
| let gitHubUsername = config.username; | ||
| if (!gitHubUsername) { |
There was a problem hiding this comment.
maybe you can extract part of this method to a separate methods, which will make the code easier to read, for example:
const gitHubUsername = await this.getGitHubUsernam(config.username);
const pluginNameSource = await this.getPluginNameSource(config.pluginName);
lib/commands/plugin/create-plugin.ts
Outdated
|
|
||
| const params = `gitHubUsername=${gitHubUsername} pluginName=${pluginNameSource} initGit=y`; | ||
| // run postclone script manually and kill it if it takes more than 10 sec | ||
| const outputScript = (await this.$childProcess.exec(`node scripts/postclone ${params}`, { cwd: cwd, timeout: 10000 })); |
There was a problem hiding this comment.
this could cause issues in case any of the parameters has a space in it. I recommend using childProcess.spawn:
const pathToPostCloneScript = path.join("scripts", "postclone");
const params = [ pathToPostCloneScript, `gitHubUsername=${gitHubUsername}`, `pluginName=${pluginNameSource}`, "initGit=y"];
await this.$childProcess.spawnFromEvent(process.execPath, params, "close", { cwd, timeout: 10000 });
lib/options.ts
Outdated
| @@ -39,7 +39,9 @@ export class Options extends commonOptionsLibPath.OptionsBase { | |||
| inspector: { type: OptionType.Boolean }, | |||
| clean: { type: OptionType.Boolean }, | |||
| watch: { type: OptionType.Boolean, default: true }, | |||
| background: { type: OptionType.String } | |||
| background: { type: OptionType.String }, | |||
| username: {type: OptionType.String}, | |||
There was a problem hiding this comment.
can you please format this changes (Alt + Shift +F in Visual Studio Code)
- $npm.install replaces $childProcess.exec("npm i")
- extract prompts to separate functions
- $childProcess.spawnFromEvent replaces $childProcess.exec
- formatting
- update tests
|
run ci |
rosen-vladimirov
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new behavior?
tns plugin createcommand added to CLI. The command will clone the plugin seed and execute the initial seed configuration script to prepare a new project for developing a NativeScript plugin.