Skip to content

Fix android livesync with sockets #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 2, 2018

Fixes the following problems with android livesync with sockets:

  1. Ensure .end is always called.
  2. Don't use doSync in refreshApplication - in case doSync fails and is called inside refreshApplication method, {N} CLI will not stop livesync.
  3. Call await doSyncPromise.then(...)
  4. Call socket.destroy() in order to fix ctrl +c problem with node version < 10

PR Checklist

@Fatme Fatme force-pushed the fatme/fix-livesync-sockets branch from 69c8b57 to 9253bbe Compare August 2, 2018 15:14
@rosen-vladimirov rosen-vladimirov added this to the 4.2.0 milestone Aug 2, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Aug 2, 2018

run ci

1 similar comment
@rosen-vladimirov
Copy link
Contributor

run ci

@KristianDD KristianDD merged commit 2aeef9e into release Aug 3, 2018
@KristianDD KristianDD deleted the fatme/fix-livesync-sockets branch August 3, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants