Skip to content

chore: update common lib to get fix for detecting iOS devices on Win #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2018
Merged

chore: update common lib to get fix for detecting iOS devices on Win #3771

merged 2 commits into from
Jul 25, 2018

Conversation

KristianDD
Copy link
Contributor

PR Checklist

What is the current behavior?

Sidekick crashes on windows machines

What is the new behavior?

Sidekick should start normally

Fixes/Implements/Closes #[Issue Number].

@KristianDD KristianDD closed this Jul 25, 2018
@KristianDD KristianDD reopened this Jul 25, 2018
Fatme
Fatme approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@Fatme Fatme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After green build

@KristianDD KristianDD merged commit 699212e into release Jul 25, 2018
@KristianDD KristianDD deleted the kddimitrov/fix-detect-ios-simulators-windows branch July 25, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fatme Fatme Fatme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristianDD @Fatme