fix: During all gradle operations "Gradle build" message is printed #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case CLI executes any Gradle operation, it always prints `Gradle build...` message. Fix this by printing specific message for each operation, for example "Gradle clean..." when clean is executed. Also make some methods private as they are used only in AndroidProjectService and they were incorrectly added to the IPlatformProjectService interface.
Fatme
approved these changes
Jul 12, 2018
dtopuzov
added a commit
to NativeScript/nativescript-cli-tests
that referenced
this pull request
Jul 12, 2018
Address changes required by: NativeScript/nativescript-cli#3744
|
run ci |
dtopuzov
added a commit
to NativeScript/nativescript-cli-tests
that referenced
this pull request
Jul 12, 2018
Address changes required by: NativeScript/nativescript-cli#3744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case CLI executes any Gradle operation, it always prints
Gradle build...message. Fix this by printing specific message for each operation, for example "Gradle clean..." when clean is executed.Also make some methods private as they are used only in AndroidProjectService and they were incorrectly added to the IPlatformProjectService interface.
PR Checklist
What is the current behavior?
When CLI calls gradle clean (for example if you call
tns build android --bundle && tns build android),Gradle build...is printed, while executing clean operation.What is the new behavior?
CLI prints correct information for the gradle task.