Skip to content

fix: Platform add hangs when invalid frameworkPath is passed #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

In case non-existent file is passed to --frameworkPath the tns platform add ... command hangs. Fix this by checking if the passed value is correct.

PR Checklist

What is the current behavior?

tns platform add android --frameworkPath invalid.tgz hangs.

What is the new behavior?

tns platform add android --frameworkPath invalid.tgz fails with error: Invalid frameworkPath: invalid.tgz. Please ensure the specified frameworkPath exists.

In case non-existent file is passed to `--frameworkPath` the `tns platform add ...` command hangs. Fix this by checking if the passed value is correct.
@rosen-vladimirov rosen-vladimirov merged commit 4686a4b into master Jul 10, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-invalid-fm-path branch July 10, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants