fix: Trying to run unit test fails with latest karma #3698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests are initialized, the `tns test <platform>` command fails in case karma 2.0.3 is used. In order to fix it, until karma resolves the issue on their side, hardcode the version of karma that is installed by CLI on `tns test init` command. Also install mocha when it is selected for testing framework. In case we do not install it, the test command fails again.
Fatme
reviewed
Jun 21, 2018
| } | ||
| ]; | ||
|
|
||
| modulesToInstall.push(...dependencies.map(f => ({ name: f }))); |
There was a problem hiding this comment.
Shouldn't be {name: 'karma-' + f }?
There was a problem hiding this comment.
nope, the required names already have karma - https://github.com/NativeScript/nativescript-cli/pull/3698/files#diff-7a3a35d2e2f3966bf14d55b5968c0257R8
Fatme
approved these changes
Jun 22, 2018
KristianDD
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests are initialized, the
tns test <platform>command fails in case karma 2.0.3 is used. In order to fix it, until karma resolves the issue on their side, hardcode the version of karma that is installed by CLI ontns test initcommand.Also install mocha when it is selected for testing framework. In case we do not install it, the test command fails again.
PR Checklist
What is the current behavior?
tns test init --framework mocha && tns test <platform>command fails to execute the tests.What is the new behavior?
The command executes the tests.
Fixes: #3689 and #2283