Emit system information of every run of the CLI #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
1 similar comment
|
✅ |
| @@ -55,11 +56,11 @@ | |||
| "shelljs": "0.3.0", | |||
| "tabtab": "https://github.com/Icenium/node-tabtab/tarball/master", | |||
| "temp": "0.8.1", | |||
| "unzip": "0.1.9", | |||
| "unzip": "0.1.11", | |||
There was a problem hiding this comment.
Is this change required - do we use unzip anywhere? If not, let's just remove it.
There was a problem hiding this comment.
It is require'd in the FS but not actually used. I will remove it.
teobugslayer
force-pushed
the
totev/sysinfo
branch
from
67fe84e to
58fd484
Compare
|
❌ |
|
✅ |
teobugslayer
force-pushed
the
totev/sysinfo
branch
from
58fd484 to
0bc9d81
Compare
|
✅ |
|
👍 |
1 similar comment
|
👍 |
| @@ -58,11 +59,10 @@ | |||
| "shelljs": "0.3.0", | |||
| "tabtab": "https://github.com/Icenium/node-tabtab/tarball/master", | |||
| "temp": "0.8.1", | |||
| "unzip": "0.1.9", | |||
| "winreg": "0.0.12", | |||
| "xcode": "https://github.com/NativeScript/node-xcode/archive/NativeScript-0.9.tar.gz", | |||
There was a problem hiding this comment.
why xcode but not node-xcode?
There was a problem hiding this comment.
This is not my code, I have no idea :) I think @fealebenpae fixed an upstream bug in this fork.
There was a problem hiding this comment.
because the name of the module in its package.json is xcode
There was a problem hiding this comment.
Basically what Rosen said.
teobugslayer
force-pushed
the
totev/sysinfo
branch
from
0bc9d81 to
6cca1f9
Compare
|
✅ |
teobugslayer
added a commit
that referenced
this pull request
Mar 26, 2015
Emit system information of every run of the CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather system information about the runtime environment.
At install time, warn about potential problems due to mis-configured environment.