Skip to content

fix(project): fix project creation when template v2 is used #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 4, 2018

PR Checklist

What is the current behavior?

An error is thrown when the user tries to create project with template v2.

What is the new behavior?

The user is able to create project with template v2.

Steps to reproduce:

  1. tns create --template https://github.com/rosen-vladimirov/test-tns-template-v2/tarball/master

@Fatme Fatme added this to the 4.1.1 milestone Jun 4, 2018
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After green build

@rosen-vladimirov
Copy link
Contributor

run ci

3 similar comments
@Fatme
Copy link
Contributor Author

Fatme commented Jun 4, 2018

run ci

@rosen-vladimirov
Copy link
Contributor

run ci

@miroslavaivanova
Copy link
Contributor

run ci

@Fatme Fatme force-pushed the fatme/fix-template-v2 branch from f805b74 to 1a9d32d Compare June 5, 2018 06:34
@Fatme Fatme merged commit c08b575 into release Jun 5, 2018
@Fatme Fatme deleted the fatme/fix-template-v2 branch June 5, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants