Skip to content

fix: fix a deprecation warning that is shown when debug command is executed using node v10 #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 29, 2018

When tns debug ios command is executed with node10, a deprecation warning is shown

(node:93714) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

PR Checklist

What is the current behavior?

Deprecation warning is shown when tns debug ios command is executed using node v10

What is the new behavior?

No deprecation warning is shown using node v10

@Fatme Fatme added this to the 4.1.1 milestone May 29, 2018
@Fatme Fatme changed the title fix: fix deprecated message that is shown when debug command is executed using node v10 fix: fix a deprecation warning that is shown when debug command is executed using node v10 May 29, 2018
@Fatme
Copy link
Contributor Author

Fatme commented May 30, 2018

run ci

@Fatme Fatme merged commit 354b999 into release Jun 1, 2018
@Fatme Fatme deleted the fatme/fix-depracated-buffer branch June 1, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants