Skip to content

Touch app.gradle file only if __PACKAGE__ placeholder exists #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 29, 2018

In case when tns run android command is executed, the app is restarted twice on device. The first restart is when the fullSync is executed and the second one is when app.gradle file is interpolated. Actually once the __PACKAGE__ placeholder is replaced inside app.gradle, there is no need to replace it again. This PR skips the interpolation of app.gradle file when there is no placeholder inside it.

Steps to reproduce:

  1. tns create myApp
  2. tns run android

PR Checklist

What is the current behavior?

The application is restarted twice on device.

What is the new behavior?

The application is restarted only once on device.

@Fatme Fatme added this to the 4.1.0 milestone May 29, 2018
@Fatme Fatme force-pushed the fatme/fix-double-ref branch from d09930a to 7397aa5 Compare May 29, 2018 11:55
@Fatme Fatme force-pushed the fatme/fix-double-ref branch from 7397aa5 to 9ff607c Compare May 29, 2018 12:02
@Fatme Fatme merged commit a6ef8a9 into release May 29, 2018
@Fatme Fatme deleted the fatme/fix-double-ref branch May 29, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants