fix: iOS debug issues #3616
Merged
fix: iOS debug issues #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
approved these changes
May 25, 2018
In case multiple iOS Simulators are running and `tns debug ios` is called, CLI prompts you to select you on which device/simulator to debug. Selecting the device and trying to debug your application leads to error as CLI does not pass correctly the device identifier. Fix this by passing the correct device identifier. Also update ios-sim-portable to latest version, where several fixes for this case are applied
The `tns debug ios --start` command fails as we do not get the port from iOS Application on device in this case. In order to fix this, start the log parsing in case --start option is passed. Also fix the attaching to ATTACH_REQUEST_EVENT_NAME - we've incorrectly attached to device's application manager, which does not emit such event. Fix it by attaching to `iOSNotification`, which is the correct one. Also remove incorrect cache decorator and ensure we do not start logging for iOS devices more than once.
Fix unit tests and use sinon to mock the timers. This way the execution of the tests for getting port is now around 50ms instead of 15 seconds
rosen-vladimirov
force-pushed
the
vladimirov/fix-ios-debug-issues
branch
from
8a6abaf to
75fb867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Unable to debug on iOS Simulator when multiple sims are running
In case multiple iOS Simulators are running and
tns debug iosis called, CLI prompts you to select you on which device/simulator to debug.Selecting the device and trying to debug your application leads to error as CLI does not pass correctly the device identifier.
Fix this by passing the correct device identifier.
Also update ios-sim-portable to latest version, where several fixes for this case are applied
fix:
tns debug ios --startfailsThe
tns debug ios --startcommand fails as we do not get the port from iOS Application on device in this case. In order to fix this, start the log parsing in case --start option is passed.Also fix the attaching to ATTACH_REQUEST_EVENT_NAME - we've incorrectly attached to device's application manager, which does not emit such event. Fix it by attaching to
iOSNotification, which is the correct one.Also remove incorrect cache decorator and ensure we do not start logging for iOS devices more than once.