fix: Unable to fast sync changes with iOS runtime 4.0.1 and earlier #3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI should be able to execute fast sync on devices and iOS Simulator (single instance) when using older runtime version (4.0.1 and prior). However, currently it just hangs as the promise that should return the port for fast sync, is never resolved. Fix this by resolving the promise in this case.
Fatme
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI should be able to execute fast sync on devices and iOS Simulator (single instance) when using older runtime version (4.0.1 and prior).
However, currently it just hangs as the promise that should return the port for fast sync, is never resolved. Fix this by resolving the promise in this case.
PR Checklist
What is the current behavior?
LiveSync of .css files on iOS devices and Simulators when iOS Runtime is 4.0.1 or earlier, just hangs.
What is the new behavior?
LiveSync of .css files is executed successfully.