Skip to content

fix: Unhandled rejection is thrown when disconnection iOS Device #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

In case iOS device is disconnected during LiveSync an unhandled rejection is thrown. The problem is in ios-device-lib, so update it to latest version - 0.4.12, where the issue is fixed.
Changelog: https://github.com/telerik/ios-device-lib/releases/tag/v0.4.12

PR Checklist

What is the current behavior?

  1. Start livesync on iOS device: tns run ios
  2. Apply some changes
  3. After they are applied, disconnect the device
  4. Unhandled rejection is thrown

What is the new behavior?

Disconnecting the device does not throw any error.

In case iOS device is disconnected during LiveSync an unhandled rejection is thrown. The problem is in ios-device-lib, so update it to latest version - 0.4.12, where the issue is fixed.
Changelog: https://github.com/telerik/ios-device-lib/releases/tag/v0.4.12
@rosen-vladimirov rosen-vladimirov added this to the 4.1.0 milestone May 23, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 23, 2018
@rosen-vladimirov rosen-vladimirov requested a review from Fatme May 23, 2018 09:46
@rosen-vladimirov rosen-vladimirov merged commit 65e41d1 into master May 24, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-ios-device-unhandled branch May 24, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants