fix(GDPR): Do not track local project paths #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/gdpr-v1
branch
2 times, most recently
from
23136f1 to
f536725
Compare
Do not track paths to projects when local template is used. Instead track `localTemplate_<name from template's package.json or dirname>`. Also fix the prompter for emails as we need to show information how to unsubscribe from the newsletter. Add tests for the behavior.
rosen-vladimirov
force-pushed
the
vladimirov/gdpr-v1
branch
from
f536725 to
af8a5d8
Compare
Fatme
reviewed
May 17, 2018
| @@ -46,5 +46,21 @@ export class ProjectTemplatesService implements IProjectTemplatesService { | |||
| this.$logger.trace(`Using NativeScript verified template: ${templateName} with version ${version}.`); | |||
| return this.$npmInstallationManager.install(templateName, projectDir, { version: version, dependencyType: "save" }); | |||
| } | |||
|
|
|||
| private getTemplateNameToBeTracked(templateName: string, realTemplatePath: string): string { | |||
There was a problem hiding this comment.
Not sure, but maybe the whole code should be in try { } catch { }. In case something fails here we don't want to stop the command execution.
There was a problem hiding this comment.
Nice idea, I've added the try-catch and test for this case.
Fatme
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not track paths to projects when local template is used. Instead track
localTemplate_<name from template's package.json or dirname>.Also fix the prompter for emails as we need to show information how to unsubscribe from the newsletter.
Add tests for the behavior.
PR Checklist
Fixes #3595