feat: Deprecate support for all macOS versions below High Sierra #3588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
approved these changes
May 16, 2018
PublicAPI.md
Outdated
| * Definition | ||
| ```TypeScript | ||
| /** | ||
| * Gets all globall warnings for the current environment, for example Node.js version compatibility, OS compatibility, etc. |
KristianDD
approved these changes
May 16, 2018
Add deprecation message in case the current macOS version is below High Sierra. As the latest Xcode versions can be installed only on this OS and we state that we support only latest Xcode, we have to deprecate the support for other OS versions. The deprecation message will be shown on each CLI command. As the deprecation messages from CLI should be shown in Sidekick as well, expose new methods in CLI's `sysInfo` moodule, so Sidekick can get the warnings and show them. In order to get the warnings for Node.js version, change the way `verifyNodeVersion` is called. Expose method for getting the currently supported Node.js version range. Add tests for the new methods.
rosen-vladimirov
force-pushed
the
vladimirov/deprecate-macos-sierra
branch
from
b3595a7 to
64bab09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecation message in case the current macOS version is below High Sierra. As the latest Xcode versions can be installed only on this OS and we state that we support only latest Xcode, we have to deprecate the support for other OS versions.
The deprecation message will be shown on each CLI command.
As the deprecation messages from CLI should be shown in Sidekick as well, expose new methods in CLI's
sysInfomoodule, so Sidekick can get the warnings and show them.In order to get the warnings for Node.js version, change the way
verifyNodeVersionis called.Expose method for getting the currently supported Node.js version range.
Add tests for the new methods.
PR Checklist
What is the current behavior?
All macOS versions are supported
What is the new behavior?
When macOS is not HighSierra, CLI prints a warning that this version will not be supported in the future.
Implements #3570