feat: Allow using JAVA 8+ #3578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
approved these changes
May 14, 2018
|
NOTE: Do not merge before releasing real version of nativescript-doctor and using it in this PR. |
KristianDD
reviewed
May 16, 2018
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip |
There was a problem hiding this comment.
Is there a particular reason we change the package from bin to all. The difference is about 22MB.
KristianDD
approved these changes
May 16, 2018
Currently in case you have JAVA 9 or 10, CLI does not allow you to build your application. Remove the check for max JAVA version from nativescript-doctor and use the rc version of the package in CLI.
rosen-vladimirov
force-pushed
the
vladimirov/java-8+
branch
from
b551a0e to
2739b17
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in case you have JAVA 9 or 10, CLI does not allow you to build your application. Remove the check for max JAVA version from nativescript-doctor and use the rc version of the package in CLI.
PR Checklist
What is the current behavior?
in case you have JAVA 9 or 10, CLI does not allow you to build your application.
What is the new behavior?
CLI allows building apps with JAVA 9 or 10.
Implements #3605