Skip to content

Fix invalid version rc when adding android platform #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fix invalid version rc when adding android platform #3483

merged 1 commit into from
Mar 22, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Mar 21, 2018

Fixes #3477

rosen-vladimirov
rosen-vladimirov approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current fix will work, but it is not scalable. A better approach is to get all tags from npm and check the version against them. This can be implemented in a separate PR.

@Fatme Fatme merged commit c3661c6 into release Mar 22, 2018
@Fatme Fatme deleted the fatme/android-rc-version branch March 22, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatme @rosen-vladimirov