chore: Merge release(3.4.3) in master #3458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angelog
Changelog for {N} v3.4.2
We need to track users that export their projects from playground and opens them in CLI or Sidekick. To support that we introduce playground key in nativescript key in package.json file. For example:
```
{
"nativescript": {
"playground": {
"id": "some user quid",
"usedTutorial": false // is not obligatory. In case it is present, can be true or false
}
}
}
```
If case when package.json file contains playground key, {N} CLI reads playground data and saves them in userSettings file. If usedTutorial=true is already saved in userSettings file, {N} CLI does not overwrite it. After that {N} CLI deletes playground key from package.json file.
In case when package.json file does not contain playground key, {N} CLI checks if playground key is already saved in userSettings file. It this is the case, {N} CLI reads playground data from userSettings file.
In case project template has a preconfigured plugins data (for example API keys), it will be stored in the template's package.json. After creating the project, CLI removes all keys except the one defined in `PackageJsonKeysToKeep` array from `app/package.json` file. So it removes the predefined configuration of the pluginData. Fix this by adding the entry "pluginsData" in the array, so we'll keep it as well.
feat(Analytics): Respect playground key from package.json file
feat(create): Keep pluginsData key from template's package.json
Update version. Update Changelog.
chore(release): Preapre for 3.4.3 release
Conflicts: PublicAPI.md lib/bootstrap.ts lib/common npm-shrinkwrap.json package.json test/platform-commands.ts test/plugins-service.ts
Mitko-Kerezov
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.