Get sysInfos based on specified platform #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Mar 13, 2018
lib/services/doctor-service.ts
Outdated
| if (platform) { | ||
| infos = this.filterInfosByPlatform(infos, platform); | ||
| } | ||
| let infos = await doctor.getInfos({ platform: platform }); |
There was a problem hiding this comment.
You can use short syntax here:
const infos = await doctor.getInfos({ platform });| @@ -42,15 +42,15 @@ class DoctorService implements IDoctorService { | |||
| if (hasWarnings) { | |||
| this.$logger.info("There seem to be issues with your configuration."); | |||
| await this.promptForHelp(); | |||
| } else { | |||
| this.$logger.out("No issues were detected.".bold); | |||
There was a problem hiding this comment.
will we print this on each tns build ... when there are no issues?
There was a problem hiding this comment.
No. This will be printed only on doctor command
Fatme
force-pushed
the
fatme/platform-specific-infos
branch
2 times, most recently
from
617d769 to
3a9b64c
Compare
rosen-vladimirov
approved these changes
Mar 14, 2018
|
run ci |
rosen-vladimirov
force-pushed
the
fatme/platform-specific-infos
branch
from
7cdda13 to
17c3d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR NativeScript/nativescript-doctor#30
Should be merged after this PR telerik/mobile-cli-lib#1064
Fixes cloud builds regression problem.