fix(livesync): respect rapid file changes #3410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 1, 2018
Mitko-Kerezov
force-pushed
the
kerezov/rapid-file-changes
branch
from
3aa8c28 to
47d3e0d
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LiveSync not respecting rapid file changes (like transpilation, or copying directories for example).
Fix this by not passing
filesToSynctoupdateAppmethod ofAppFilesUpdater. This way each file will be copied upon every LiveSync action and we won't miss out any files.Ping @rosen-vladimirov