refactor: introduce shouldprepare hook #3399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitko-Kerezov
force-pushed
the
kerezov/should-prepare
branch
from
37c3f4c to
5f46293
Compare
rosen-vladimirov
approved these changes
Feb 28, 2018
lib/services/platform-service.ts
Outdated
| @@ -187,13 +187,25 @@ export class PlatformService extends EventEmitter implements IPlatformService { | |||
| return _.filter(this.$platformsData.platformsNames, p => { return this.isPlatformPrepared(p, projectData); }); | |||
| } | |||
|
|
|||
| public async preparePlatform(platformInfo: IPreparePlatformInfo): Promise<boolean> { | |||
| @helpers.hook('shouldPrepare') | |||
| public async shouldPrepare(platformInfo: IPreparePlatformInfo, changesInfo?: IProjectChangesInfo): Promise<boolean> { | |||
There was a problem hiding this comment.
maybe it is better to pass a single object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
shouldPreparehook.Needed in order for plugins to be able to state when a project should undergo the prepare process.
Ping @rosen-vladimirov