Skip to content

feat(doctor): Integrate nativescript-doctor package #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

feat(doctor): Integrate nativescript-doctor package #3390

merged 1 commit into from
Feb 28, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Feb 23, 2018

Mitko-Kerezov
Mitko-Kerezov approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay AFAICS

lib/services/doctor-service.ts Outdated

const hasAndroidWarnings = warnings.filter(warning => _.includes(warning.platforms, "Android")).length > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use $devicePlatformsConstants.Android here instead of hardcoding the string directly

@Fatme Fatme force-pushed the fatme/doctor-package-integration branch 3 times, most recently from 8cea41a to 9ec6ea9 Compare February 28, 2018 06:06
@Fatme Fatme force-pushed the fatme/doctor-package-integration branch from 9ec6ea9 to 19d8478 Compare February 28, 2018 07:13
@Fatme Fatme merged commit 61f4b6c into master Feb 28, 2018
@Fatme Fatme deleted the fatme/doctor-package-integration branch February 28, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mitko-Kerezov Mitko-Kerezov Mitko-Kerezov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatme @Mitko-Kerezov