feat(sidekick): Support clean option when executing local builds in Sidekick #3386
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fatme
commented
Feb 21, 2018
Fatme
commented
- Expose cleanNativeApp method for Sidekick
- Fix run, deploy and build commands when clean option is specified
- Fix help of build and deploy commands
Fatme
force-pushed
the
fatme/clean-native-app
branch
2 times, most recently
from
13e288a to
ed2d1d7
Compare
dtopuzov
added a commit
to NativeScript/nativescript-cli-tests
that referenced
this pull request
Feb 22, 2018
- Verify incremental native build - Verify clean build rebuild native project - Assert build times (with safe tolerance)
rosen-vladimirov
approved these changes
Feb 25, 2018
lib/definitions/project.d.ts
Outdated
| cleanNativeApp(data: ICleanNativeAppData): Promise<void>; | ||
| } | ||
|
|
||
| interface ICleanNativeAppData { |
There was a problem hiding this comment.
There are already interfaces IProjectDir and IPlatform, so you can just inherit them:
interface ICleanNativeAppData extends IProjectDir, IPlatform;
Fatme
force-pushed
the
fatme/clean-native-app
branch
2 times, most recently
from
f2a06d4 to
45373a7
Compare
…ocal builds * Expose cleanNativeApp method for Sidekick * Fix run, deploy and build commands when clean option is specified * Fix help of build and deploy commands
Fatme
force-pushed
the
fatme/clean-native-app
branch
from
45373a7 to
bc9d242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.