refactor(livesync): speedup livesync #3362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Feb 13, 2018
lib/services/app-files-updater.ts
Outdated
| @@ -81,6 +79,7 @@ export class AppFilesUpdater { | |||
| return this.fs.createDirectory(destinationPath); | |||
| } | |||
|
|
|||
| console.log(`Copying ${source} to ${destinationPath}`); | |||
There was a problem hiding this comment.
This is actually a forgotten debug message, will remove
Mitko-Kerezov
force-pushed
the
kerezov/speedup-livesync
branch
from
a4ffa28 to
fbf8cf2
Compare
|
Ping @rosen-vladimirov with fixed comments |
rosen-vladimirov
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup LiveSync with the following optimizations:
--syncAllFilesis passed. This was unnecessary and leads to a 2 s delay in angular projectsplatforms/.../appdirectory, then copy all files from the project's app directory and then only upload the changed ones. Change the implementation so that only changed files are copied and uploaded.Ping @rosen-vladimirov @KristianDD