fix(CLI): Increase inspector installer memory buffer. #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ export class NpmInstallationManager implements INpmInstallationManager { | |||
| } | |||
|
|
|||
| if (shouldInstall) { | |||
| await this.$childProcess.exec(`npm install ${inspectorNpmPackageName}@${version} --prefix ${cachePath}`); | |||
| await this.$childProcess.exec(`npm install ${inspectorNpmPackageName}@${version} --prefix ${cachePath}`, { maxBuffer: 250 * 1024 }); | |||
There was a problem hiding this comment.
the default value is 200*1024 , is it enough to just add 50 KB more?
There was a problem hiding this comment.
@rosen-vladimirov it seems to be enough for the installation to succeed.
rosen-vladimirov
approved these changes
Feb 6, 2018
tdermendjiev
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an out-of-memory problem with the installation of the tns-ios-inspector module from @next. There is a
maxBuffersize allowed for thestdoutorstderrof the child process. It seems with the updated inspector sources we exceed that. The defaultmaxBuffersize is200 * 1024bytes according to NodeJS' docs. 50KB more seem to resolve the problem.