fix(debug): debug-brk option does not work for iOS Simulator #3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
requested review from
KristianDD,
Mitko-Kerezov and
TsvetanMilanov
lib/services/ios-debug-service.ts
Outdated
| const socket = await this.$iOSEmulatorServices.connectToPort({ port: inspectorBackendPort }); | ||
| if (!socket) { | ||
| private async waitForBackendPortToBeOpened(deviceIdentifier: string): Promise<void> { | ||
| const portListens = await this.$net.waitForPortToListen(inspectorBackendPort, 10000, 200); |
There was a problem hiding this comment.
Introducing an object instead of passing three separate values here would increase readability a lot IMO
rosen-vladimirov
force-pushed
the
vladimirov/fix-sim-debug-brk
branch
2 times, most recently
from
cd4d340 to
0216235
Compare
Mitko-Kerezov
approved these changes
Jan 30, 2018
rosen-vladimirov
force-pushed
the
vladimirov/fix-sim-debug-brk
branch
from
0216235 to
2ed4507
Compare
The `debug-brk` option was broken in a previous commit as we were trying to connect to the backend port (18181). The problem is that connecting to it makes the runtime thinks debugger is attached and it continues to next statements. Instead of connecting to the port, check if it is in LISTEN state.
rosen-vladimirov
force-pushed
the
vladimirov/fix-sim-debug-brk
branch
from
2ed4507 to
b35a8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
debug-brkoption was broken in a previous commit as we were trying to connect to the backend port (18181). The problem is that connecting to it makes the runtime thinks debugger is attached and it continues to next statements.Instead of connecting to the port, check if it is in LISTEN state.
Fixes #3338