Fix multiple typescript/sass watchers #3332
Conversation
| @@ -527,7 +527,7 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi | |||
|
|
|||
| const currentWatcherInfo = this.liveSyncProcessesInfo[liveSyncData.projectDir].watcherInfo; | |||
|
|
|||
| if (!currentWatcherInfo || currentWatcherInfo.pattern !== pattern) { | |||
| if (!currentWatcherInfo || currentWatcherInfo.pattern.toString() !== pattern.toString()) { | |||
There was a problem hiding this comment.
It might be good to sort the array (if its an array) so that the order of patterns doesn't matter.
There was a problem hiding this comment.
Actually, pattern is always an array as it can be seen here. currentWatcherInfo.pattern on the other hand is always an array too as it is actually the same pattern .
So there is no need to sort the array, as both arrays always have the same order.
@KristianDD what do you think?
There was a problem hiding this comment.
@Mitko-Kerezov But as seen here it can be a string. And as I will add configurations for livesync the patterns might change.
Mitko-Kerezov
force-pushed
the
kerezov/multiple-ts-watchers
branch
from
f553e9c to
a6165ec
Compare
|
Ping @KristianDD and @rosen-vladimirov. In light of @KristianDD's suggestion I decided to take a different approach to this. |
Whenever using CLI as a library, calling livesync multiple times leads to multiple typescript/sass watchers. This happens due to the fact that `currentWatcherInfo.pattern` is an array and checking two arrays for equality with `!==` is bound to return `true` at all times. `toString()` both arrays and check the string literals instead.
Mitko-Kerezov
force-pushed
the
kerezov/multiple-ts-watchers
branch
from
a6165ec to
3f01716
Compare
| @@ -526,8 +526,8 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi | |||
| } | |||
|
|
|||
| const currentWatcherInfo = this.liveSyncProcessesInfo[liveSyncData.projectDir].watcherInfo; | |||
|
|
|||
| if (!currentWatcherInfo || currentWatcherInfo.pattern !== pattern) { | |||
| const areWatcherPatternsDifferent = () => _.difference(currentWatcherInfo.pattern, pattern).length || _.difference(pattern, currentWatcherInfo.pattern).length; | |||
There was a problem hiding this comment.
You might use _.xor(currentWatcherInfo.pattern, pattern).length (not sure, should be checked).
There was a problem hiding this comment.
Was looking for this, thanks!
lib/definitions/livesync.d.ts
Outdated
| @@ -60,7 +60,7 @@ interface ILiveSyncProcessInfo { | |||
| timer: NodeJS.Timer; | |||
| watcherInfo: { | |||
| watcher: IFSWatcher, | |||
| pattern: string | string[] | |||
| pattern: string[] | |||
There was a problem hiding this comment.
Optional: would look better if the property is called patterns.
Whenever using CLI as a library, calling livesync multiple times leads to multiple typescript/sass watchers.
This happens due to the fact that
currentWatcherInfo.patternis an array and checking two arrays for equality with!==is bound to returntrueat all times.toString()both arrays and check the string literals instead.Ping @KristianDD @rosen-vladimirov