Fix build for android below 21 #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In res directory there's values directory that is required for all android versions and directory called values-v21, which is required only for Android version 21. In case you do not have installed latest Android version, this directory should not be added to your project. Add copyResValues method, which copies res/values directory and res/values-v<version_number> directory to your project. This way when we add directories for other android versions, they will not break builds for older ones. Fixes #299
|
Test PASSed. |
|
👍 |
1 similar comment
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 16, 2015
…ion-builds Fix build for android below 21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In res directory there's values directory that is required for all android versions and directory called values-v21, which is required only for Android version 21. In case you do not have installed latest Android version, this directory should not be added to your project.
Add copyResValues method, which copies res/values directory and res/values-v<version_number> directory to your project. This way when we add directories for other android versions, they will not break builds for older ones.
Fixes #299