Skip to content

Remove moment as dependency #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented Dec 11, 2017

Remove moment.js as dependency as it is not used in the code.

Update shrinkwrap as several dependencies have been added, but shrinkwrap has not been regenerated since then.

Merge after telerik/mobile-cli-lib#1034

@rosen-vladimirov rosen-vladimirov self-assigned this Dec 11, 2017
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove moment.js as dependency as it is not used in the code.

Update shrinkwrap as several dependencies have been added, but shrinkwrap has not been regenerated since then.
@rosen-vladimirov rosen-vladimirov merged commit c493408 into master Dec 11, 2017
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/remove-moment branch December 11, 2017 14:51
rosen-vladimirov added a commit that referenced this pull request Dec 11, 2017
Remove moment.js as dependency as it is not used in the code.

Update shrinkwrap as several dependencies have been added, but shrinkwrap has not been regenerated since then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants