Use proxy-lib package when working behind proxy #3253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
The `proxy-lib` package provides required methods for setting and getting proxy. Its implementation is more secure when stroing credentials, so switch to it instead of current implementation. Remove the credentials-manager from CLI as it is no longer needed. Remove the CredentialsManager.exe as well and its source code. Fix the error `Cannot read property ExceptionMessage of null` when wokring behind proxy - add correct null checks. Fix tracking to google analytics behind proxy - pass the proxy URL to Universal Analytics module.
rosen-vladimirov
force-pushed
the
vladimirov/proxy
branch
from
1b28700 to
4e744a7
Compare
|
run ci |
rosen-vladimirov
added a commit
that referenced
this pull request
Dec 11, 2017
The `proxy-lib` package provides required methods for setting and getting proxy. Its implementation is more secure when stroing credentials, so switch to it instead of current implementation. Remove the credentials-manager from CLI as it is no longer needed. Remove the CredentialsManager.exe as well and its source code. Fix the error `Cannot read property ExceptionMessage of null` when wokring behind proxy - add correct null checks. Fix tracking to google analytics behind proxy - pass the proxy URL to Universal Analytics module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
proxy-libpackage provides required methods for setting and getting proxy. Its implementation is more secure when stroing credentials, so switch to it instead of current implementation.Remove the credentials-manager from CLI as it is no longer needed.
Remove the CredentialsManager.exe as well and its source code.
Fix the error
Cannot read property ExceptionMessage of nullwhen wokring behind proxy - add correct null checks.Fix tracking to google analytics behind proxy - pass the proxy URL to Universal Analytics module.