Skip to content

parse npm install results correctly #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017
Merged

parse npm install results correctly #3213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/node-package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,12 @@ export class NodePackageManager implements INodePackageManager {
});

// Npm 5 return different object after performing `npm install --dry-run`.
// Considering that the dependency is already installed we should
// find it in the `updated` key as a first element of the array.
// We find the correct dependency by searching for the `userSpecifiedPackageName` in the
// `npm5Output.updated` array and as a fallback, considering that the dependency is already installed,
// we find it as the first element.
if (!name && npm5Output.updated) {
const updatedDependency = npm5Output.updated[0];
const packageNameWithoutVersion = userSpecifiedPackageName.split('@')[0];
const updatedDependency = _.find(npm5Output.updated, ['name', packageNameWithoutVersion]) || npm5Output.updated[0];
return {
name: updatedDependency.name,
originalOutput,
Expand Down