Skip to content

Fix showing default help (from index.md) #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

rosen-vladimirov
Copy link
Contributor

In case user executes:

  • tns help - we should show the default index.html help with all commands
  • tns --help - we should show the default command line help generated from index.md file with all commands

This has been broken during changing html-help-service to help-service.
Fix the default behavior and add tests for it.

Merge after telerik/mobile-cli-lib#1024

Fix for #3204

In case user executes:
- `tns help` - we should show the default index.html help with all commands
- `tns --help` - we should show the default command line help generated from index.md file with all commands

This has been broken during changing html-help-service to help-service.
Fix the default behavior and add tests for it.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-default-help branch from 4c307f5 to 54861b9 Compare November 9, 2017 09:04
@rosen-vladimirov
Copy link
Contributor Author

run ci

Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@rosen-vladimirov
Copy link
Contributor Author

run ci

@rosen-vladimirov
Copy link
Contributor Author

Merging as the failure is caused by infrastructure.

@rosen-vladimirov rosen-vladimirov merged commit e181f03 into master Nov 9, 2017
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-default-help branch November 9, 2017 11:57
rosen-vladimirov added a commit that referenced this pull request Nov 13, 2017
In case user executes:
- `tns help` - we should show the default index.html help with all commands
- `tns --help` - we should show the default command line help generated from index.md file with all commands

This has been broken during changing html-help-service to help-service.
Fix the default behavior and add tests for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants