Do not break CLI process in case analytics fail #3197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
requested review from
nadyaA,
Mitko-Kerezov and
TsvetanMilanov
Mitko-Kerezov
suggested changes
Nov 6, 2017
| const helpers = require("../../../lib/common/helpers"); | ||
| const originalIsInteractive = helpers.isInteractive; | ||
|
|
||
| const trackFeatureUsage = "TrackFeatureUsage"; |
There was a problem hiding this comment.
This could be extracted to constants and reused in here
There was a problem hiding this comment.
I disagree - the purpose here is to use it for the tests, it could easily be named in other way.
| broker.unref(); | ||
|
|
||
| let isSettled = false; | ||
| try { |
There was a problem hiding this comment.
I don't believe this try { ... } catch (ex) { ... } statement will manage to actually catch anything. More likely you'd get an unhandled rejection if something throws inside the new Promise
| const originalSetTimeout = setTimeout; | ||
| childProcess.spawn = (command: string, args?: string[], options?: any): any => { | ||
| opts.isChildProcessSpawned = true; | ||
| const spawnedProcess = new EventEmitter(); |
There was a problem hiding this comment.
Getting this spawnedProcess can be extracted into a function - along with setting its stdout, stderr and unref methods
|
run ci |
rosen-vladimirov
force-pushed
the
vladimirov/analytics-do-not-fail
branch
from
552abaf to
f0bbdc7
Compare
In case we are unable to start the Analytics Broker process, CLI will fail. But analytics errors should not break user's workflow, so catch the error and ensure the actions will continue. Add tests to verify the behavior.
rosen-vladimirov
force-pushed
the
vladimirov/analytics-do-not-fail
branch
from
f0bbdc7 to
1215d43
Compare
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 13, 2017
In case we are unable to start the Analytics Broker process, CLI will fail. But analytics errors should not break user's workflow, so catch the error and ensure the actions will continue. Add tests to verify the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we are unable to start the Analytics Broker process, CLI will fail. But analytics errors should not break user's workflow, so catch the error and ensure the actions will continue.
Add tests to verify the behavior.
Also limit the waiting for broker to start to 10 seconds.