Fix asking for user's emails on postinstall and starting of emualtor on tns debug #2919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/fix-email-check
branch
from
e8e43fc to
adcd755
Compare
… attached `tns debug <platform>` command should start emulator in case device is not attached. The current command does not start emulator as we have passed `skipInferPlatform` - when this option is used, devicesService does not know for which platform to start the emulator. Fix this by passing correct options.
On postinstall CLI asks the users if they want to subscribe for NativeScript's newsletter. This check has been broken in 3.0.0 because of incorrect await. In order to add tests for this functionality, introduce a new service that handles the check and sending of information about the user's mail. Add the following tests: - ensure postinstall.js calls correct CLI command - ensure the post-install-cli command calls the new service - ensure the new service works correctly
Update ios-device-lib to 0.4.7, which will fix livesync of `.css` files on iOS Device after application has been restarted.
rosen-vladimirov
force-pushed
the
vladimirov/fix-email-check
branch
from
8c6fb50 to
e5ba743
Compare
nadyaA
approved these changes
Jun 26, 2017
TsvetanMilanov
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix starting of emulator on
tns debug <platform>when device is not attachedtns debug <platform>command should start emulator in case device is not attached. The current command does not start emulator as we have passedskipInferPlatform- when this option is used, devicesService does not know for which platform to start the emulator.Fix this by passing correct options.
Fixes #2916
Fix asking for user email on postinstall
On postinstall CLI asks the users if they want to subscribe for NativeScript's newsletter. This check has been broken in 3.0.0 because of incorrect await.
In order to add tests for this functionality, introduce a new service that handles the check and sending of information about the user's mail.
Add the following tests:
Fixes CLI does not ask new users to subscribe for NativeScript newsletter #2923
Fix livesync of .css files on iOS devices
In case the application has been restarted during livesync, the fast sync of
.xmland.cssis not working anymore for iOS devices. The problem is inios-device-lib, where the incorrect socket had been closed. Fix this by updating the library to its latest version.Fixes #2879