Reimplement livesync #2883
Merged
Reimplement livesync #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
requested review from
dtopuzov,
pkoleva,
rosen-vladimirov and
TsvetanMilanov
|
Current implementation restart the app on each css and xml change, we need to fix it. |
pkoleva
approved these changes
Jun 9, 2017
|
run ci |
rosen-vladimirov
suggested changes
Jun 12, 2017
lib/commands/debug.ts
Outdated
| debugData.pathToAppPackage = this.$platformService.lastOutputPath(this.debugService.platform, buildConfig, projectData); | ||
|
|
||
| this.printDebugInformation(await this.debugService.debug<string[]>(debugData, debugOptions)); | ||
| // TODO: Fix this call |
lib/commands/debug.ts
Outdated
| @@ -114,29 +132,37 @@ export class DebugIOSCommand extends DebugPlatformCommand { | |||
| super.printDebugInformation(information); | |||
| } | |||
| } | |||
|
|
|||
| public platform = "iOS"; | |||
There was a problem hiding this comment.
use a constant here
lib/commands/debug.ts
Outdated
| return await super.canExecute(args) && await this.$platformService.validateOptions(this.$options.provision, this.$projectData, this.$platformsData.availablePlatforms.Android); | ||
| } | ||
|
|
||
| public platform = "Android"; |
There was a problem hiding this comment.
use a constant here
lib/definitions/livesync.d.ts
Outdated
| useLiveEdit?: boolean; | ||
| } | ||
|
|
||
| interface ILatestAppPackageInstalledSettings { |
There was a problem hiding this comment.
interface should be IDictionary<IDictionary<boolean>>
| @@ -75,7 +75,7 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact | |||
|
|
|||
| public async createWebSocketProxy(factory: () => Promise<net.Socket>): Promise<ws.Server> { | |||
| // NOTE: We will try to provide command line options to select ports, at least on the localhost. | |||
| const localPort = await this.$net.getAvailablePortInRange(8080); | |||
| const localPort = await this.$net.getFreePort(); | |||
There was a problem hiding this comment.
why is this changed?
There was a problem hiding this comment.
Because it didn't work with multiple iOS devices. For some reason the second device's socket connection could not be established due to an EADDRINUSE error.
It did work for Android however but I decided it was not worth the research at the time - we don't actually lose anything with this change other than the fact that every debug session will be on a random port rather than the first being on 8080, the second on 8081 and so on.
| } | ||
|
|
||
| private async startWatcher(projectData: IProjectData, | ||
| liveSyncData: ILiveSyncInfo): Promise<void> { |
There was a problem hiding this comment.
this can be moved on the line above
|
|
||
| if (liveSyncInfo.filesToRemove.length) { | ||
| const filePaths = liveSyncInfo.filesToRemove; | ||
| let platformData = this.$platformsData.getPlatformData(device.deviceInfo.platform, projectData); |
| } | ||
|
|
||
| if (existingFiles.length) { | ||
| let platformData = this.$platformsData.getPlatformData(device.deviceInfo.platform, projectData); |
|
|
||
| const mappedFiles = _.map(filePaths, filePath => this.$projectFilesProvider.mapFilePath(filePath, device.deviceInfo.platform, projectData)); | ||
| const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, APP_FOLDER_NAME); | ||
| let localToDevicePaths = await this.$projectFilesManager.createLocalToDevicePaths(deviceAppData, projectFilesPath, mappedFiles, []); |
lib/services/platform-service.ts
Outdated
| @@ -545,8 +554,9 @@ export class PlatformService extends EventEmitter implements IPlatformService { | |||
| } | |||
|
|
|||
| private async getDeviceBuildInfoFilePath(device: Mobile.IDevice, projectData: IProjectData): Promise<string> { | |||
| let deviceAppData = this.$deviceAppDataFactory.create(projectData.projectId, device.deviceInfo.platform, device); | |||
| let deviceRootPath = path.dirname(await deviceAppData.getDeviceProjectRootPath()); | |||
| // let deviceAppData = this.$deviceAppDataFactory.create(projectData.projectId, device.deviceInfo.platform, device); | |||
|
👍 After green builds. |
dtopuzov
approved these changes
Jun 12, 2017
Expose * saveBuildInfoFile - method which should be used in cloud builds * livesyncService - which can be used to perform livesync with require-d tns
In case the app is not installed on a device when `tns run <platform>` is started, each change reinstalls the application. The problem is in the "isApplicationInstalled" check which was relying on the result of the first execution (when the app has not been installed). Fix this by always checking if the app is installed.
Mitko-Kerezov
force-pushed
the
vladimirov/new-livesync
branch
from
74a5f07 to
c6127ea
Compare
rosen-vladimirov
force-pushed
the
vladimirov/new-livesync
branch
from
9ba0f87 to
083f3f6
Compare
rosen-vladimirov
approved these changes
Jun 14, 2017
We need to explicitly skip this step on Windows due to lack of tooling that is properly licensed.
nadyaA
force-pushed
the
vladimirov/new-livesync
branch
from
083f3f6 to
f32f243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require()-dtns runcommand that will be executed on all available devices (iOS and Android on macOS, Android on all other OSes).Merge after telerik/mobile-cli-lib#974
Ping @rosen-vladimirov @TsvetanMilanov