[Do not merge] Update Android SDK Packages in setup scripts #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchimev
commented
May 22, 2017
| echo y | cmd /c "$androidExecutable" update sdk --filter "build-tools-23.0.3" --all --no-ui | ||
| echo y | cmd /c "$androidExecutable" update sdk --filter "extra-android-m2repository" --all --no-ui | ||
| $androidExecutable = [io.path]::combine($env:ANDROID_HOME, "tools", "bin", "sdkmanager") | ||
| echo y | cmd /c "$androidExecutable" "platform-tools" |
There was a problem hiding this comment.
Unable to test, perhaps it should be escaped.
vchimev
commented
May 22, 2017
| } | ||
| echo y | cmd /c "$androidExecutable" "system-images;android-25;google_apis;x86" |
There was a problem hiding this comment.
Let's both scripts for macOS and Windows do the same.
To consider:
- creating an emulator based on the installed image
- referring to Android Virtual Devices article
There was a problem hiding this comment.
Can we install android-23 images?
Reason:
- It is the most used version
- Boots faster
|
I'm closing this pull request in favour of: |
vchimev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and verified for macOS.
Updated but NOT verified for Windows - @etabakov, would appreciate your help here.