Respect current version of CLI when searching for runtimes #2793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
May 9, 2017
dtopuzov
approved these changes
May 9, 2017
|
run ci |
|
@dtopuzov can you confirm this regression test fails in 2.5.4 official, too? So that we can proceed with the merge with 1 regression test failing (as it's fixed in 3.x) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for the ios/android runtimes respect the current version of the CLI and don't search only for matching versions - i.e. if I have CLI 2.5.4 don't look for runtimes >= 2.5.4 only, as they can be available only up to 2.5.2 which is still fine and working for us. So I've changed it to look for 2.5.x or major.minor.any compatible versions of the packages, when searching for them.
Replaces $npm.install with the $npmInstallationManager.install
Updated the semver, to add the prerelease function missing in the last version