Pass correct args to ios-sim-portable's stopApplication #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
approved these changes
May 4, 2017
When Xcode 8 or later is installed, ios-sim-portable will spawn `xcrun simctl terminate <device id> <app id>` in order to stop the application. For earlier version the command for stopping the app is `killall <app name>`. So pass correct args to the method. Update ios-sim-portable, where the change is implemented.
rosen-vladimirov
force-pushed
the
vladimirov/fix-stop-start-sim-app
branch
from
cbdcaca to
cf3e10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Xcode 8 or later is installed, ios-sim-portable will spawn
xcrun simctl terminate <device id> <app id>in order to stop the application.For earlier version the command for stopping the app is
killall <app name>. So pass correct args to the method.NOTE: Merge only after the ios-sim-portable version is bumped (i.e. after merging NativeScript/ios-sim-portable#90).
NOTE2: Merge after telerik/mobile-cli-lib#953
Fixes NativeScript/ios-jsc#761
and
#2732